瀏覽代碼

x/model: be more clear slice bound for CompleteNoBuild

Also, update TODO.
Blake Mizerany 1 年之前
父節點
當前提交
2f241692bd
共有 1 個文件被更改,包括 1 次插入4 次删除
  1. 1 4
      x/model/name.go

+ 1 - 4
x/model/name.go

@@ -252,9 +252,6 @@ var builderPool = sync.Pool{
 	},
 }
 
-// TODO(bmizerany): Add WriteTo and use in String and MarshalText with
-// strings.Builder and bytes.Buffer, respectively.
-
 // String returns the fullest possible display string in form:
 //
 //	<host>/<namespace>/<model>:<tag>+<build>
@@ -331,7 +328,7 @@ func (r Name) Complete() bool {
 // CompleteNoBuild is like [Name.Complete] but it does not require the
 // build part to be present.
 func (r Name) CompleteNoBuild() bool {
-	return !slices.Contains(r.parts[:Tag], "")
+	return !slices.Contains(r.parts[:Build-1], "")
 }
 
 // EqualFold reports whether r and o are equivalent model names, ignoring