Explorar el Código

ollamarunner: Don't panic for unimplemented features at runtime.

It's ok to fail on startup but we shouldn't panic during runtime
based on user input. Downgrade the panic to a warning.
Jesse Gross hace 1 mes
padre
commit
4614fafae0
Se han modificado 1 ficheros con 3 adiciones y 4 borrados
  1. 3 4
      runner/ollamarunner/runner.go

+ 3 - 4
runner/ollamarunner/runner.go

@@ -436,10 +436,9 @@ func (s *Server) processBatch() error {
 		// if done processing the prompt, generate an embedding and return
 		// if done processing the prompt, generate an embedding and return
 		if seq.embeddingOnly {
 		if seq.embeddingOnly {
 			// TODO(jessegross): Embedding support
 			// TODO(jessegross): Embedding support
-			// s.removeSequence(i, "")
-			// continue
-
-			panic("generation of embedding outputs not yet supported")
+			slog.Warn("generation of embedding outputs not yet supported")
+			s.removeSequence(i, "")
+			continue
 		}
 		}
 
 
 		// sample a token
 		// sample a token