Browse Source

x/model: add note about future changes to Name for memory efficiency

Blake Mizerany 1 year ago
parent
commit
712eaa4b09
1 changed files with 6 additions and 0 deletions
  1. 6 0
      x/model/name.go

+ 6 - 0
x/model/name.go

@@ -91,6 +91,12 @@ const (
 type Name struct {
 	_     structs.Incomparable
 	parts [NumParts]string
+
+	// TODO(bmizerany): track offsets and hold s (raw string) here? We
+	// could pack the offests all into a single uint64 since the first
+	// parts take less bits since their max offset is less than the max
+	// offset of the next part. This would save a ton of bytes per Name
+	// and mean zero allocations for String.
 }
 
 // ParseName parses s into a Name. The input string must be a valid string