Przeglądaj źródła

server: return empty slice on empty `/api/embed` request (#5713)

* server: return empty slice on empty `/api/embed` request

* fix tests
Jeffrey Morgan 9 miesięcy temu
rodzic
commit
7ac6d462ec
2 zmienionych plików z 7 dodań i 3 usunięć
  1. 1 1
      api/types.go
  2. 6 2
      server/routes_test.go

+ 1 - 1
api/types.go

@@ -206,7 +206,7 @@ type EmbedRequest struct {
 // EmbedResponse is the response from [Client.Embed].
 type EmbedResponse struct {
 	Model      string      `json:"model"`
-	Embeddings [][]float32 `json:"embeddings,omitempty"`
+	Embeddings [][]float32 `json:"embeddings"`
 }
 
 // EmbeddingRequest is the request passed to [Client.Embeddings].

+ 6 - 2
server/routes_test.go

@@ -306,8 +306,12 @@ func Test_Routes(t *testing.T) {
 					t.Fatalf("expected model t-bone, got %s", embedResp.Model)
 				}
 
-				if embedResp.Embeddings != nil {
-					t.Fatalf("expected embeddings to be nil, got %v", embedResp.Embeddings)
+				if embedResp.Embeddings == nil {
+					t.Fatalf("expected embeddings to not be nil, got %v", embedResp.Embeddings)
+				}
+
+				if len(embedResp.Embeddings) != 0 {
+					t.Fatalf("expected embeddings to be empty, got %v", embedResp.Embeddings)
 				}
 			},
 		},