소스 검색

backend: Don't return an error on Close

It is not common to return errors with close/free operations - most
people won't check it and even if they did there's probably not much
that can do. It's better to not give implementations false expectations.
Jesse Gross 2 달 전
부모
커밋
7e13f568dc
2개의 변경된 파일2개의 추가작업 그리고 3개의 파일을 삭제
  1. 1 1
      ml/backend.go
  2. 1 2
      ml/backend/ggml/ggml.go

+ 1 - 1
ml/backend.go

@@ -50,7 +50,7 @@ type Context interface {
 
 
 	Forward(Tensor)
 	Forward(Tensor)
 	Compute(Tensor) Tensor
 	Compute(Tensor) Tensor
-	Close() error
+	Close()
 }
 }
 
 
 type Tensor interface {
 type Tensor interface {

+ 1 - 2
ml/backend/ggml/ggml.go

@@ -306,10 +306,9 @@ func (c Context) FromIntSlice(s []int32, shape ...int) (ml.Tensor, error) {
 	return fromSlice(c, s, shape, C.GGML_TYPE_I32)
 	return fromSlice(c, s, shape, C.GGML_TYPE_I32)
 }
 }
 
 
-func (c *Context) Close() error {
+func (c *Context) Close() {
 	C.ggml_backend_sched_free(c.sched)
 	C.ggml_backend_sched_free(c.sched)
 	C.ggml_free(c.ctx)
 	C.ggml_free(c.ctx)
-	return nil
 }
 }
 
 
 type Tensor struct {
 type Tensor struct {